Repository navigation
Conversation
Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #642, which fixed
PooledClient.getsbut leftPooledClient.gatsbehind.PooledClient.gatsnow takescas_defaultand passesexpire,defaultandcas_defaultthrough toClient.gats, matching theClient.gatssignature and return type.ignore_exc=True,PooledClient.gatsreturned the baredefaulton error instead of a(value, cas)tuple, which brokevalue, cas = client.gats(key). It now returns(default, cas_default).ignore_exc=True,PooledClient.getsreturned(None, None)on error and ignored the caller's defaults. It now returns(default, cas_default).Tests: added
TestPooledClienttests forgats(found, not found with defaults) and for theignore_excerror path ofgetsandgats. The error path tests use an inner client that raises, since the pooled clients are always created withignore_exc=False. The full unit and integration suite passes.Fixes #665